Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ami doc update and few typo and indentation fixes #2045

Merged
merged 3 commits into from
Oct 25, 2017

Conversation

abinashmeher999
Copy link
Contributor

I don't mean to nitpick the slightest of errors. I am just trying to contribute with whatever low hanging issues I can find. :) Kindly have a look.

Documentation Update

Reasoning for docs update

  • Fixes inconsistent indentation (f081c8e)
  • Typo in CHANGELOG, fixed in (27fe2af)
  • Mention in the docs for r/ami that we can't use encrypted with snapshot_id (6c1bd5d)

Relevant Terraform version

The typo fix was made to 1.1.0 part of CHANGELOG, the rest don't refer to a specific Terraform version but are relevant for the latest docs on the website. There is no immediate need to deploy it to the site.

@radeksimko radeksimko added the documentation Introduces or discusses updates to documentation. label Oct 25, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@radeksimko radeksimko merged commit 03c0ae7 into hashicorp:master Oct 25, 2017
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants